joltup / rn-fetch-blob

A project committed to making file access and data transfer easier, efficient for React Native developers.
MIT License
2.81k stars 771 forks source link

Fix addAndroidDownloads for paths containing % #745

Closed juliar closed 2 years ago

juliar commented 2 years ago

Before this fix, specifying a path in the addAndroidDownloads option containing a "%" character would result in an error when downloading.

This is because in one place in the code when reading the path value, we assume the value is URI encoded, whereas in another place, we assume it is not URI encoded.

I updated the code to consistently assume the path is not URI encoded.

With this fix, downloading now works correctly for us for paths containing a "%" character when we specify the path unencoded.

retyui commented 2 years ago

Hi This module is unmentionable ⚠️! please use fork: https://github.com/RonRadtke/react-native-blob-util