search

joltwallet / esp_littlefs

LittleFS port for ESP-IDF
MIT License
254 stars 95 forks source link

fix the bug: if LITTLEFS_SDMMC_SUPPORT turns on, some features are pr… #172

Closed wang33winner closed 7 months ago

wang33winner commented 7 months ago

…oblematic when using flash. some macro for CONFIG_LITTLEFS_SDMMC_SUPPORT will drop the work for flash

wang33winner commented 7 months ago

@huming2207 can you take a look at this? There appears to be 3 real changes among the formatting/linting changes.

yes, some "endif" modifications are also required, others are formatting/linting changes.

BrianPugh commented 7 months ago

the code changes look good to me, I'll merge in a day or two (unless huming2207 provides back sooner).

huming2207 commented 7 months ago

I've reviewed the code - frankly speaking I don't know what is this for. Instead, this PR will definitely break SD card support.

I really don't think the LITTLEFS_SDMMC_SUPPORT will affect any existing LittleFS functionalities on SPI NOR flash over esp_partition. My colleagues are also using v1.13 for production on SPI NOR flash and they have no complaints so far. I will double check with them on next Monday.

huming2207 commented 7 months ago

Oh I'm really sorry, I misread the code on iPad 😅😅

I think it's fine. I will test it with our real devices and see if that actually cause any issues on Monday. On the other hand so far I didn't hear any report about breaking on esp_partition on SPI flash though, I will double check again with my colleagues...

huming2207 commented 7 months ago

Hi @BrianPugh we've tested it and we believe it's all good to go.