jolynloh / pe

0 stars 0 forks source link

Phone number with exactly 8 digits too restrictive #8

Open jolynloh opened 1 year ago

jolynloh commented 1 year ago

This is especially so if users want to add country tags, e.g. "+65" to the phone numbers

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Overzealous Phone Number Validation

image.png

As the target user is "tech leads" and not "teach leads based for companies based in Singapore", the validation of only 8 digits long phone number is inappropriate, as numbers from other parts of the world do not consist of exactly 8 digits


[original: nus-cs2103-AY2223S1/pe-interim#5772] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As of right now, it is rather difficult to implement a differentiation of phone number by countries. It is possible to have 2 same phone number from 2 different countries so for now, we restrict it to just Singapore phone numbers. In future implementation, we will implement country code tagging to the phone number to fix this issue.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Allowing varying number of digits for phone numbers is not difficult to implement (e.g. 5-15 digits which is the maximum number of digits of any phone number in the world, instead of restricting to strictly 8 digits).

Furthermore, given that the target audience did not specify Singapore tech leads or companies, the justification for restricting to only Singapore phone numbers seem weak. A better approach would have been to mention in the UG that support for varying number of digits in phone numbers would be coming up in a future iteration so that users are aware (and readers know that the developers have considered this limitation of the app).


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: image.png

It seems like overzealous input validation is a case of feature flaw instead of functionality bug.


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]