search

jombo23 / N64-Tools

N64 Tools
The Unlicense
239 stars 113 forks source link

N64 Sound Bank/Midi Tool - Problems with Toy Story 2 #29

Open fotisandstuff opened 2 years ago

fotisandstuff commented 2 years ago

Hello! I would like to report an issue with the export of soundbanks from the game Toy Story 2. The exported DLS' sample mappings don't match the bank/program numbers in the midi tracks (especially the drums, they're all wrong). I haven't had this issue with other games so far.

SubDrag commented 2 years ago

Nothing looks out of the ordinary to me...sorry I don't know. Maybe you can mess and see if it's offset by one or something. Seems pretty standard...sng midis and one n64wavptr bank.

fotisandstuff commented 2 years ago

It just got worse... The latest edition of N64 Sound Tool cannot even load the ROM now. It shows an error message that says "Unsupported inst type in ALInst". I had no problems whatsoever with the latest editions of Midi and Soundbank Tools.

SubDrag commented 2 years ago

Sorry you're right, should be fixed now in latest push (that error, not the Toy Story other issues).

fotisandstuff commented 2 years ago

Excellent, it works now. Thank you! Merry Christmas!

SubDrag commented 2 years ago

Did you ever take a song and see if was a fixed offset or what the correct instrument mapping was? It would help with original issue.

fotisandstuff commented 2 years ago

So, I've done some experiments with the track "Andy's Room". Ableton is reading the rest of the instrument mappings correctly, but the drum mappings are seemingly one value higher than they should be (e.g. it reads the kick drum as being Program 62, while it is, in fact, Program 61). I'm guessing this is an Ableton issue and I can fix it by hand. FL Studio 20 has no problem reading the correct values for all instruments; however, there is still an issue with instrument tuning. In the video below, I'm comparing the USF rip of the song (in foobar2000) to the midi+DLS as loaded in FL Studio. You can clearly hear that the instruments sound out of tune in FL.

https://drive.google.com/file/d/1rnr43jAn3CCiTYvks--r9AwngEDPQE_d/view?usp=sharing

SubDrag commented 2 years ago

Are you able to analyze and see individually how far each is off? Or a pattern of some kind.

fotisandstuff commented 2 years ago

I can't figure out a pattern about the wrong tuning, because I loaded a different song (the Game Over one) and the tuning seems to be fine. However, I do notice a pattern with the drum sounds; again, the value is Program 14 in Ableton and Program 13 in FL (the correct one). I don't know why Ableton reads the drum midi programs wrong...