search

jombo23 / N64-Tools

N64 Tools
The Unlicense
239 stars 113 forks source link

N64 MidiTool doesn't export every Midi in Perfect Dark #3

Closed SoundTheHorn closed 4 years ago

SoundTheHorn commented 5 years ago

After exporting all Midis for Perfect Dark, I noticed there were a lot of midis were missing. When I looked through the tool's folders to see if I was able to fix this, I found, in gameconfig.ini, there were 119 listed Midis for Perfect Dark (U) (V1.1), gameconfigini but, instead of all 119 listed in the .ini, I was only able to export 63 midis, which is very strange. miditool glitch I've tried the tool with other games, and I've seen that there is no cap of 63, so why this is happening with Perfect Dark specifically, I do not know.

SubDrag commented 5 years ago

This is a simple copy/paste bug. It should say while (currentBinaryNumber < 0x77) under ProcessMidis for PerfectDark game, not, in N64MidiToolReader.cpp if someone wants to fix it...It was accidentally 0x3F.

SoundTheHorn commented 4 years ago

The issue has been fixed with the newest release. Thanks for the help!