jombo23 / N64-Tools

N64 Tools
The Unlicense
239 stars 113 forks source link

Fix bug with MarioParty2E SFX banks #33

Closed Raspberryfloof closed 2 years ago

Raspberryfloof commented 2 years ago

MarioParty2E SBF0 banks had a bug where far less than the correct number of sound effects were viewable/dumpable if they were using the format that Mario Party 2 and Mario Party 3 use for their SBF0 banks. This doesn't seem to affect any other games that used this format besides specifically Mario Party 2 and 3, because the previous check was whether the halfword before the start of the data was nonzero, which in Mario Party 1's case (and likely other games' too) it was zero, so the correct data was used instead.

I tested this patch in a version of the project converted to compile in Visual Studio 2017, but only submitted the patched file without the changes to make it VS2017 compatible.