search

jomiller / vscode-rtags

RTags Client for Visual Studio Code
GNU General Public License v3.0
10 stars 0 forks source link

rc error handling is not robust #2

Closed jomiller closed 6 years ago

jomiller commented 6 years ago

Errors from running rc may not always be handled well. Exceptions from running execFile() are not caught. The reject() function is never called in the Promise executor. catch() is never called on returned Thenable objects.

jomiller commented 6 years ago

I believe that all sources of errors are now handled appropriately. Errors in the Promise executor are intentionally handled through resolve() rather than reject().