search

jomjol / AI-on-the-edge-device

Easy to use device for connecting "old" measuring units (water, power, gas, ...) to the digital world
https://jomjol.github.io/AI-on-the-edge-device-docs/
6.12k stars 658 forks source link

settings>wlan update #1629

Open nliaudat opened 1 year ago

nliaudat commented 1 year ago

The Feature

I mean there is no reason to have two ini config files. Moving all params of wlan.ini to config.ini may be productive as the wlan.ini is not actually backuped (in the backup tools).

It's also difficult to change wifi parameter without removing the sdcard.

Regards

jomjol commented 1 year ago

I didn't want the WLAN passsword in clear text to be inside a direct accessable configuration. Therefore we have put the network information into a dedicated file and protected this file from direct access.

nliaudat commented 1 year ago

I understand you security concern, but the password can be ciphered in the text file.

nliaudat commented 1 year ago

An "update Wlan" function could be implemented in the "settings>wlan update" without revealing the last setting and make changes in wlan.ini

That way, the wlan.ini stays, but it's possible to update without removing sdcard. What do you think of that ?

Regards

jomjol commented 1 year ago

That would be another option. Bye the way, that is how the hostname is changed in the wlan.ini

caco3 commented 1 year ago

just keep in mind that it would need an update for all existing users.

I have seen it at least once that the config file got corrupted during write, eg. due to a power cycle in the wrong moment. This would also break wifi and require rewriting the SD card. Because of this I would suggest to keep it separate as is now.

gomble commented 10 months ago

Is this feature request on the plan? I mean it is only copy and paste of this block for ssid and password?

https://github.com/jomjol/AI-on-the-edge-device/blob/d2c47fcde2c038fe40413aeee1c3858486c19a71/code/components/jomjol_wlan/read_wlanini.cpp#L188

caco3 commented 10 months ago

AFAIK nobody is working on this. But we are open for Pull Requests. Just keep my conserns in mind. Also, beside the discussion in this issue there are hardly discussions about this feature.