GVExport preferences partially behind the webtrees menu

jon48 / webtrees-theme-rural

Rural theme for webtrees

GNU General Public License v3.0

11 stars 2 forks source link

GVExport preferences partially behind the webtrees menu #42

Closed TheDutchJewel closed 1 year ago

TheDutchJewel commented 2 years ago

When using the GVExport module by @tillsc (for webtrees 2.0.x) or by @Neriderc (for webtrees 2.1.x) and Rural, it is not possible to close the Diagram preferences because the close button is behind the webtrees menu.

Here is a screenshot with the default webtrees theme: afbeelding

And here a screenshot with the Rural theme: afbeelding

jon48 commented 2 years ago

Which browser are you using?

I have tried reproducing on Chrome 101, Firefox 100 and Edge 101, with the following configurations, and in all cases, the preferences window displayed above the menu.

webtrees 2.0.23 - Rural theme 2.0.23-v.1 - tillsc/GVExport@master
webtrees 2.1.2 - Rural theme 2.1.1-v.1 - Neriderc/GVExport@master

TheDutchJewel commented 2 years ago

I tried it with Edge 101, Firefox 100 and Opera 86: they all have the same problem.

TheDutchJewel commented 2 years ago

Aha, the problem is caused by the Vesta Classic Look & Feel module: if I disable that one then the problem is solved.

vytux-com commented 2 years ago

So you are trying to use two theme modules at the same time... Of cause this is not going to work well

TheDutchJewel commented 2 years ago

@vytux-com

So you are trying to use two theme modules at the same time...

Why do you think that?

I only use the Rural theme and in case of problems I show how it looks with the default webtrees theme.

vytux-com commented 2 years ago

@vytux-com

So you are trying to use two theme modules at the same time...

Why do you think that?

I only use the Rural theme and in case of problems I show how it looks with the default webtrees theme.

The classic laf is basically a theme module it's supposed to convert webtrees modern theme into webtrees classic (V1) theme.

Using it on any other theme is just asking for trouble

jon48 commented 2 years ago

The classic laf is basically a theme module it's supposed to convert webtrees modern theme into webtrees classic (V1) theme.

Using it on any other theme is just asking for trouble

I have raised that concern on the issue raised by @TheDutchJewel on the Classic Look & Feel repository. Even though it is not advertised as is, it is indeed closed to a theme module, and I feel it should only apply when a standard theme is selected, not for the other custom themes, as CSS conflicts are quite likely (or in a more controlled manner).

ric2016 commented 2 years ago

@jon48 Can you give an example of a conflicting css definition from the Classic Look & Feel module? I don't notice any obvious issues when using both modules together (except from this one, which is actually about a third custom module).

Using it on any other theme is just asking for trouble

No, it is supposed to work together with themes in general. Note also that it has several non-theming-related aspects.

hartenthaler commented 1 year ago

Using the latest version of the Vesta modules this error is solved now. So from my point of view, this issue can be closed now.