search

jon48 / webtrees-theme-rural

Rural theme for webtrees
GNU General Public License v3.0
11 stars 2 forks source link

2.0.4-v.1 - More space for logo on login page #5

Closed TheDutchJewel closed 4 years ago

TheDutchJewel commented 4 years ago

On the login page, the logo (150px height) disappears behind the text: afbeelding

Is it possible to move the text section down to make room for the logo?

jon48 commented 4 years ago

Hello, You are actually missing a large part of the header (the Search form, and even the main menu), as you can see in the screenshot below, I am struggling to reproduce this issue on the browsers I use.

Could you please precise what browser you are using, and if you have tried on other ones? Are you using the standard logo, or a personal one? Do you see this issue on all pages, or only the login page?

Capture_Rural_#2

TheDutchJewel commented 4 years ago

Tested configurations

  1. Desktop pc with Windows10 x64 Home v1909 and latest versions of Edge (83.0.478.44), Firefox (77.0.1), Waterfox (2020.06), Chrome (83.0.4103.97), Vivaldi (3.0.1874.38).
  2. Tablet with Android 8.1.0. Tested with online (private) and offline page (XAMPP v7.3.18-0).

Same problem in all browsers, only on login page, with and without logo. I just created a demo one for the schreenshot.

TheDutchJewel commented 4 years ago

Here is a screenshot of the login page with the default logo: afbeelding

I am struggling to reproduce this issue on the browsers I use.

You should see it when you log out.

jon48 commented 4 years ago

OK, I see it now, this is happening when none of your trees are available to visitors (in my case, I always have at least one). In that case, neither the search box, nor the tree title are displayed, and I am missing two third of my header, and the height is too small.

I am going to think about that use case, as I can now reproduce.

jon48 commented 4 years ago

And the fix was pretty obvious actually.

The only issue I still see with that use case is that I cannot have the white section with the round corners, as is usually the case when a menu is displayed, because the CSS logic for it is in the navigation pane, and the main section does not have a way to know that the navigation pane is not displayed (except maybe through some JavaScript, but that may be overkilled),

Happy with the rather empty right side?

image

TheDutchJewel commented 4 years ago

Happy with the rather empty right side?

No problem with that. Thanks for fixing!

jon48 commented 4 years ago

I will go with it then. I am waiting just a bit in case of further general feedback, but will probably release a new version with the latest fixes tomorrow.