jon48 / webtrees-theme-rural

Rural theme for webtrees
GNU General Public License v3.0
11 stars 2 forks source link

Change in the way to edit the name of a record in the new version of RURAL #52

Closed BernatBanyuls closed 1 year ago

BernatBanyuls commented 1 year ago

In the new version, the [v] symbol under the name to check your registration has disappeared. You now go directly to the editing screen (by clicking on the pencil). This is not bad, but I need the previous step because some of my records have "common notes" that I can't read now. It appears for a few seconds on the screen, but the system quickly goes to edit and does not allow reading. In other presentations it does NOT happen, only in RURAL and it is my preferred presentation mode. See if you can help me.

(I hope I made myself clear) Thank you.

jon48 commented 1 year ago

Sorry, I do not visualise what "[v] symbol under the name to check your registration" you are referring to. Would you mind sending a screenshot or the path to the page?

At a first glance, I am a bit surprised any behaviour is changed by the theme, as it is only a CSS theme (no HTML override nor additional JavaScript), so only display should be impacted. But when I have located the area you are describing, maybe I will be able to find something.

BernatBanyuls commented 1 year ago

Let's see. I understand that it is a bit difficult to explain and the only way to recover the image would be with a previous version. In the screenshot I point out in a red circle where before there was an icon that allowed you to see the registry data. If you then had to change something, you clicked on the pencil icon. In screenshot 1 is what I see in the current edition and in screenshot 2 the icon that appeared before in the area marked in screenshot 1. image

image

In the other presentations everything is fine, but in Rural there is a jump of one or two seconds that goes from "show name record" to "name edition". (I hope this doesn't just happen to me, I wouldn't understand why).

jon48 commented 1 year ago

I am still not sure I understand which icon was displayed (and disappeared), as there should be nothing under the name. From your screenshot, I however believe that you have some other modules installed (at least Vesta), as some of the displays are not the standard ones (the page title/name does not have the same information, the icons for editing are not visible in the standard theme, there is a Sex bar below the Name, the Facts tabs is the Vesta one).

image

In the native webtrees, the edit buttons should appear when you open the name information.

image

Could you please provide a screenshot when switching to another theme for which the icon appear? As well, could you please temporarily disable the custom modules, and check that the name accordion behave as expected?

BernatBanyuls commented 1 year ago

We continue... I have been going through all the "submissions" and they have all removed the icon I claim. Only the "MINIM" presentation (attached images) keeps it. When I click on this icon, the registration information appears in an "accordion". For me it is important the information I add in the "note" and which refers to a small study of the surname. Currently, in the rest of the "presentations" this "accordion" icon has disappeared and I can only click on the pencil icon. When I do so, the action that appears is the example in image #2, but it "doesn't stop". That is, in a second it disappears and goes straight to the edit screen. I think you can try to add a text in the "common note" of an individual and you will see how it is impossible to read it when you visit this page. errornote1 errornote1_rural

errornote2 b-1963-45d7-ba5e-a5606e13c740.jpg) 92-48a8-bb1d-e11d13602567.jpg)

errornote2_rural

errornote3 errornote3_rural

errornote4 errornote4_rural

jon48 commented 1 year ago

OK, thanks. I think this is clearer to me. I do not think that the [v] should appear in any theme except Minimal. The [v] is actually the Bootstrap default, but this is replaced by the little triangle on the left in most themes.

image

If a [v] was appearing before, it is more likely that a custom module was interfering with the theme, and preventing the expected CSS to be applied. Even on the Rural theme, as far back as webtrees 1.7, this was a triangle that was appearing.

[EDIT: actually, I found one screenshot of your site in the webtrees forum. I looks like you were using a version of the theme not compatible with the version of webtrees, like theme 2.1.x on webtrees 2.0.x or vice-versa. The design is not the one expected]

image

You should not click on the icons on the right to open the accordion, but anywhere else on the bar (again, those icons are not there in the standard webtrees, you probably are using some custom modules that are changing the display). If you click on the icons, that will redirect you to the appropriate edit page instead.

wt_ISS52

If this is not what you are observing, please temporarily disable custom modules (the ones you copied in the /modules_v4/ folder), and that should work as expected.

BernatBanyuls commented 1 year ago

Perfect!!!!

Please excuse me.

Indeed, that's what I was looking for, but as I always did it using the icon (v) and now I didn't have it, I thought you had modified it.

Again, thanks for your help and a thousand apologies for my clumsiness.

Everything works perfectly and I take this opportunity to congratulate you for your "rural" for me is the best by far. Thank you.

jon48 commented 1 year ago

Great, glad we could get to the bottom of it.

Enjoy webtrees!