search

jonaburg / picom

A lightweight compositor for X11 (previously a compton fork)
Other
961 stars 100 forks source link

Phisch's animation code #10

Open Barbaross93 opened 4 years ago

Barbaross93 commented 4 years ago

Not an issue, just thought I would bring this to your attention as a reference. This is another fork of Picom with animations, and they're pretty decent: https://github.com/Tanish2002/picom/commit/18fbd43b500a67246668b288e00f9388e7d5df29. I like this fork a little more since it includes options to personalize the animations, but unfortunately it is a bit buggy. Phisch's code has no options to adjust the animations AFAIK. Hopefully Phisch's code can help give some direction for this fork.

jonaburg commented 4 years ago

thanks! interesting fork indeed, i've been trying to make progress on this quite slowly, chiefly to animate windows as they spawn in, as well as figure out XCB a bit more so window managers that take advantage of extended hints can have a leg to animate tag/window changes as well. so i'm definitely happy to see what approach he took with it! unfortunately on my machine that fork will crash on me occasionally, but it stays stable enough for me to see the effect and get some inspiration from the code as well :)

Tanish2002 commented 3 years ago

@jonaburg and @Barbarossa93 You can use @phisch 's code for some inspiration but I request you to not make a pull request to master with his code as he is working on in it a private repo whenever he has spare time. I asked him for a diff for the changes he made as I was uncomfortable using a binary and he was kind enough to give it to me but he said to not make a pull request as he first wanted to polish the code and then make a PR himself. Also my repo is public because some of my friends like me were uncomfortable to use a binary wanted to build the binary themselves.

phisch commented 3 years ago

I am not really working on it, i just implemented very basic transition support based on window position changes (no transitions for window map and unmap events yet) and made them look good by using an ease-in-out function. Got too lazy to continue with it to be honest. :/

edit: and i don't want to make a pull request because i know its hacky shit code, and i'd be mad if someone tries to push trash code like that to my projects.