jonaisahhh / ETI-Assignment

ETI Assignment Group 5
0 stars 0 forks source link

Code implementation for feature 3 #13

Open rayner77 opened 4 years ago

rayner77 commented 4 years ago

The development time is in the github, please refer if need be. If you need any help, let me know ya.

Arm57ar commented 4 years ago

Hi @kazooie20 i have test the View Maze but does not show the output

jonaisahhh commented 4 years ago

@Arm57ar - Do you have a screenshot of what is being shown ?

Arm57ar commented 4 years ago

@jonaisahhh the code is correct but it would not shown due to my files being messed up

Arm57ar commented 4 years ago

image

rayner77 commented 4 years ago

@Arm57ar I sent u the code on discord already haha. But anyways it is becuase your read_csv() is indented, move the read_csv() line of code to align with the def read_csv() function and your program should work :)

Arm57ar commented 4 years ago

@kazooie20 thanks can work already

Arm57ar commented 4 years ago

import sys import csv import time

def read_csv():

print(fileoutput)

file_directory = "D:\\NgeeAnn\\Year3_Sems_2\\ETI_Module\\Python\\maze.csv"
with open(file_directory,'rt') as csvfile:

    spamreader = csv.reader(csvfile)
    for row in spamreader:
        #print(', '.join(row))
        print(row)
#menu()

read_csv()

rayner77 commented 4 years ago

Code implementation complete by Arm57r, can go ahead with QA tests and liase with Arm57r if any problems faced during QA stage

rayner77 commented 4 years ago

@Arm57ar Please remember to commit your unit test cases once you have passed them.

ShahrulNizamBR commented 4 years ago

Hi,

I faced some issues when testing the View Maze feature. Have a look at the problem from the screenshot attached. Do apply the necessary fix to the problem.

Thanks.

view maze bug
Arm57ar commented 4 years ago

@ShahrulNizamBR noted

Arm57ar commented 4 years ago

@ShahrulNizamBR kindly check whether its working

ShahrulNizamBR commented 4 years ago

Hi @Arm57ar ,

There is another problem for the feature which is shown in the screenshot. I can run a manual test without any problems, but encountered this problem when I run pytest. Have a look in it and rectify the necessary changes. Thank you.

View maze fileoutput not defined
Arm57ar commented 4 years ago

@ShahrulNizamBR noted

rayner77 commented 4 years ago

@Arm57ar 1.Most likely is the variable Fileoutput does not exist. 2.And for ViewMaze.py the syntax is if(show):

  1. Try adding a line at the top Fileoutput = []
ShahrulNizamBR commented 4 years ago

Hi,

Testing has been conducted. The feature is able to view the selected maze file, however, did not pass the failing test due to assertion error.

View Maze attempt 3