search

jonallured / braze_ruby

A wrapper gem for the Braze REST API.
MIT License
18 stars 21 forks source link

Endpoint for 'remove email address from spam' #32

Closed brrusselburg closed 3 years ago

brrusselburg commented 3 years ago

Documentation

Adding the endpoint that lets one remove a list of email addresses from Braze's spam list.

jonallured commented 3 years ago

Thanks @brrusselburg this looks legit but wasn't built on CircleCI due to #35 - I hope to address that and then maybe we can trigger this PR to build with a rebase? Will report back soon!

jonallured commented 3 years ago

Hey @brrusselburg can you rebase on latest main branch - that should cause CircleCI to build and verify this work. Thanks!

brrusselburg commented 3 years ago

Hey @brrusselburg can you rebase on latest main branch - that should cause CircleCI to build and verify this work. Thanks!

Was on vacation, but on it now! Thanks for the heads up.

jonallured commented 3 years ago

Hey @brrusselburg I wanted to call out that you can run bundle exec rake on your local machine to simulate the CircleCI behavior. It'll first run standardrb and then rspec. I think you'll find that there are standardrb violations here and I think those can be fixed with bundle exec standardrb --fix. Hope that helps!!

brrusselburg commented 3 years ago

Hey @brrusselburg I wanted to call out that you can run bundle exec rake on your local machine to simulate the CircleCI behavior. It'll first run standardrb and then rspec. I think you'll find that there are standardrb violations here and I think those can be fixed with bundle exec standardrb --fix. Hope that helps!!

Thank you! That helped with most of the lint issues. It looks like Circle CI is still not happy? When I run locally it's passing.

Screen Shot 2021-07-15 at 09 44 59

jonallured commented 3 years ago

Hi again @brrusselburg I took the liberty of cloning down your work, fixing the violations, rebasing and pushing to this PR - hope that's ok! It's back to green so I'm going to merge and cut a release with this work. Thanks again for contributing!! 🎉 🏆

brrusselburg commented 3 years ago

Hi again @brrusselburg I took the liberty of cloning down your work, fixing the violations, rebasing and pushing to this PR - hope that's ok! It's back to green so I'm going to merge and cut a release with this work. Thanks again for contributing!! 🎉 🏆

Absolutely fine, thanks a ton!