search

jonallured / braze_ruby

A wrapper gem for the Braze REST API.
MIT License
19 stars 21 forks source link

Add support for campaign ids in scheduled messages #40

Closed jacobherrington closed 3 years ago

jacobherrington commented 3 years ago

This change allows developers to pass in a campaign_id parameter when scheduling messages.

jacobherrington commented 3 years ago

@jonallured The docs look like they contradict a bit about this parameter:

...
"campaign_id": (optional, string) see campaign identifier,
...
campaign_id | Required | String | See campaign identifier.

It's been a few hours since I looked at this, but I think the campaign_id is only required if one of the other params is missing.

I'll update the old VCRs today.

jonallured commented 3 years ago

I think this one is stale now? Or at least we don't specifically need it. 🤷

jacobherrington commented 3 years ago

@jonallured We don't specifically need it, but it could be useful to someone.

We can definitely close it until we either remove or reconfigure VCR, though.