jonallured / braze_ruby

A wrapper gem for the Braze REST API.
MIT License
19 stars 21 forks source link

Release a new version of gem #48

Closed dgalarza closed 2 years ago

dgalarza commented 2 years ago

Would it be possible to release a new version of the gem with https://github.com/jonallured/braze_ruby/pull/47 in it?

Happy to help as well if you'd like to add me as an owner.

jonallured commented 2 years ago

Ok I just invited you - I think that's all that's required? Then in terms of cutting a release this is how I've been doing it:

$ ./bin/release OLD NEW

I would be super happy if you were able to run that command and it "just worked" but if you have trouble or even if you have ideas about making it easier to release I'm down for that type of feedback!! 🙌

dgalarza commented 2 years ago

bin/release worked for the most part. Only snag I hit was when it tried to push up to main. I received:

braze_ruby main % bin/release  0.7.0 0.8.0                                
+ old_version=0.7.0                                                                                                                                                                                                                                                                                     
+ new_version=0.8.0                                                                                                                                                                                                                                                                                     
+ version_files='lib/braze_ruby/version.rb Gemfile.lock'                                                                                            
+ commit_message='Bumping version numbers for 0.8.0'                                                                                                                                                                                                                                                    
+ tag_message='Tagging version 0.8.0'                                                                                                               
+ sed -i '' s/0.7.0/0.8.0/g lib/braze_ruby/version.rb Gemfile.lock        
+ git add .                                                               
+ git commit --message 'Bumping version numbers for 0.8.0'                
[main 541412c] Bumping version numbers for 0.8.0                          
 1 file changed, 1 insertion(+), 1 deletion(-)                            
+ git push origin main                                                    
Enumerating objects: 9, done.                                             
Counting objects: 100% (9/9), done.                                       
Delta compression using up to 10 threads                                  
Compressing objects: 100% (5/5), done.                                    
Writing objects: 100% (5/5), 479 bytes | 479.00 KiB/s, done.              
Total 5 (delta 3), reused 0 (delta 0), pack-reused 0                                                                                                
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.                                                                               
remote: error: GH006: Protected branch update failed for refs/heads/main.                                                                           
remote: error: 3 of 3 required status checks are expected.               
To github.com:jonallured/braze_ruby.git                                                                                                             
 ! [remote rejected] main -> main (protected branch hook declined)                                                                                                                                                                                                                                      
error: failed to push some refs to 'github.com:jonallured/braze_ruby.git'

I went ahead and opened a PR with the version bump since I believe it wants CI passing on the commits before they get merged into main.

dgalarza commented 2 years ago

braze_ruby v0.8.0 is out. Since the bin/release stopped at the point of attempting to push the commit up I manually created the tag and pushed it up to match the convention of the tag created by bin/release. I'll close this out since the release is out.

jonallured commented 2 years ago

tyyyy 🙌