search

jonamuen / sql-reduce

A Reduction Tool for SQL Bachelor's thesis of Jonas Müntener
16 stars 1 forks source link

README.md should explain what the "reduction" of SQL means #1

Open eyalroz opened 4 years ago

eyalroz commented 4 years ago

Someone recommended this tool to me... but when I visited the main page of the repository - I couldn't understand what it actually does...

README.md is missing:

  1. Explanation of what the "reduction" of SQL means.
  2. An example of a specific context in which one wants to "reduce" an SQL query.
  3. An example of an SQL query before and after "reduction" in the example context.
jonamuen commented 4 years ago

Thank you for bringing this to my attention! I tried to address your points in the "Purpose" section in the latest commit on master. Please let me know if my explanations are unclear or if you have follow-up questions.

eyalroz commented 4 years ago

This is much much better!

Just one minor point: It seems the reduction is focused more on structural complexity and/or number of syntax tree elements than on length-in-characters. So instead of "reduce the length", I would say "reduce the complexity, and most likely also the length".

Also, I don't want to nitpick too much, but you could clarify whether it's assumed the errors/crashes are consistently reproducible and not intermittent.