search

jonas-kaufmann / NowPlaying-for-TIDAL

Imitate Spotify's Now Playing feature in Discord using Game Activity
MIT License
9 stars 0 forks source link

Add Artwork Handling #3

Closed clean-sys closed 3 years ago

clean-sys commented 3 years ago

Overview

Adds Artwork Handling i was talking about from the "issue" 2 days ago.

This pretty much a base implementation and requires the user to manually type in the variables for their MFAToken and APPID in DiscordRPC.cs.

If an asset with a matching album name is found it will use the asset image for the LargeImage and the "tidal" asset key for the SmallImage, Sound Quality being the SmallText. (LOSSLESS, HI_RES, STANDARD)

If an asset match is not found then the app will upload through Discord's API and return after that because there is a delay between assets being uploaded and when they can be used. This way we keep the default tidal image and not just have text because of an "invalid" asset, a native windows toast also shows if the upload was successful or not.

Screenshots

Artwork

Artwork-Uploading

jonas-kaufmann commented 3 years ago

First of all, thank you very much. I am now going to make everything more user friendly by implementing a config file plus performing some adjustments here and there. All of this will happen on a separate branch and when ready, I will merge it into master.

jonas-kaufmann commented 3 years ago

Sorry for force pushing, I did not intend to cover up your commit. It's my first time dealing with a pull request. If you would like to have this changed or know how to fix it, let me know.

clean-sys commented 3 years ago

Nah, don't worry about. I appreciate the work you put in to make it more user friendly and the code cleanup you did. Great job!