jonas-p / go-shp

Go library for reading and writing ESRI Shapefiles. Pure Golang implementation based on the ESRI Shapefile technical description.
MIT License
255 stars 68 forks source link

Use free CI and analysis systems #13

Closed fawick closed 6 years ago

fawick commented 6 years ago

I am going to tackle these over the next couple of days.

Edit: Added Goreportcard

fawick commented 6 years ago

Hi @jonas-p, it looks like I indeed still lack the admin role for this repo, so I cannot add the necessary webhooks for appveyor. In case you'd rather not to give admin permissions or would prefer not to include CI support, please let me know and I will roll back the changes accordingly.

jonas-p commented 6 years ago

Hi, I'm not sure it's possible to assign more granular permissions (according to https://help.github.com/articles/permission-levels-for-a-user-account-repository/), unless you know a way :).

Other than that, I think CI is a great idea and should definitely be part of the project. I see you've added files for travis/hound/appveyor so adding webhooks for them shouldn't be a problem for me.

fawick commented 6 years ago

Perfect, thanks!

I also would love to add a badge for https://goreportcard.com/report/github.com/jonas-p/go-shp and start working on improving the results. For we would need a webhook that issues a POST request to https://goreportcard.com/report/github.com/jonas-p/go-shp, I think.

fawick commented 6 years ago

@jonas-p any update on the webhooks?

jonas-p commented 6 years ago

@fawick Webhooks for appveyor and goreportcard (pinging the url you mentioned) should be active now!

fawick commented 6 years ago

Thank you!

fawick commented 6 years ago

Sorry to bother you again but it looks like hound, codecov, and travis need some webhooks or activation from your end, as well. Otherwise PRs are not checked automatically.

jonas-p commented 6 years ago

I've reactivated Travis CI and Hound, I'll tackle codecov next. I assume existing PRs aren't run until they are updated in some way!