search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
396 stars 56 forks source link

Disable default-features for HALs #112

Closed dbrgn closed 4 years ago

dbrgn commented 4 years ago

Otherwise we'll get conflicting memory configs.

Closes #88

jonas-schievink commented 4 years ago

Hmm, this will mean that users cannot depend on rubble-nrf5x without also depending on the HAL. I wonder if that's okay?

dbrgn commented 4 years ago

Well, the current state is not being able to use rubble-nrf5x at all, unless depending on the same (default) device variant :wink:

What we could also do is passing through the features:

[features]
xxAA-package = ["nrf52832-hal/xxAA-package"]
xxBB-package = ["nrf52832-hal/xxBB-package"]

...however, that gets messy quickly (especially if the HAL adds more flags). I think the probability of an application that depends on rubble-nrf5x but not also on the HAL is very low.

jonas-schievink commented 4 years ago

Yeah, I think it's a clear improvement.

dbrgn commented 4 years ago

Thanks!