search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
396 stars 56 forks source link

rubble-nrf5x: Add utils::get_device_address #113

Closed dbrgn closed 4 years ago

dbrgn commented 4 years ago

This puts device address extraction code that most dependent crates will use into a utility function.

Instead of putting it in a utils module, we could also put it in a address module if you'd prefer that.

Note: The rubble-nrf5x adds a new dependency on byteorder, but that dependency was already there indirectly through rubble.

jonas-schievink commented 4 years ago

This would close https://github.com/jonas-schievink/rubble/issues/89 – also, that issue notes that the &FICR reference is not necessary.

Other than that this look great, thanks!

dbrgn commented 4 years ago

Ah, good point with the direct FICR access.

dbrgn commented 4 years ago

Updated!