I included a fix for the last remaining header not implementing FromBytes/ToBytes in this PR, as that made removing byteorder easily. This could also be submitted separately, if you want.
I think the majority of places byteorder was used were more than well covered by the new from/to_le/be_bytes methods on integers. A few places where we're actually using it to read/write to byte slices needed more changes, mainly using copy_from_slice or try_into to convert &[u8] to [u8; N].
daboross
commented
4 years ago
I included a fix for the last remaining header not implementing
FromBytes/ToBytesin this PR, as that made removingbyteordereasily. This could also be submitted separately, if you want.I think the majority of places
byteorderwas used were more than well covered by the newfrom/to_le/be_bytesmethods on integers. A few places where we're actually using it to read/write to byte slices needed more changes, mainly usingcopy_from_sliceortry_intoto convert&[u8]to[u8; N].Let me know how this looks?
Fixes #24. CC #122.