jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
398 stars 55 forks source link

reply to LL_VERSION_IND once per connection #154

Closed JOE1994 closed 3 years ago

JOE1994 commented 3 years ago

Hello ! :crab:

This PR is for issue #49 . (relevant to Version Exchange procedure section of bluetooth 5.2 core specs)

I added a bool member to Connection that keeps track of whether we had previously sent a Control PDU LL_VERSION_IND for the connection. I also added a new variant VersionIndSent to enum LlcpError.

It is also mentioned in #49 that eventually we want to collapse all bool state variables to a single byte as bitflags, but I didn't make that change in this PR. So I guess the issue should be kept open?

Thank you for reviewing this PR ! :+1: