search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
397 stars 56 forks source link

feat: company id working #44

Closed fmckeogh closed 5 years ago

fmckeogh commented 5 years ago

Closes #38

fmckeogh commented 5 years ago

I know I've done something very wrong, because binary size is absolutely exploding here. cargo run loads 138152 bytes on this branch, versus 71148 bytes on master.

jonas-schievink commented 5 years ago

I know I've done something very wrong, because binary size is absolutely exploding here. cargo run loads 138152 bytes on this branch, versus 71148 bytes on master.

This probably happens because we debug-print ControlPdu, which contains a CompanyId, whose Debug impl calls name, which pulls in all the name strings.

fmckeogh commented 5 years ago

Yup, my bad, it isn't causing any issues with release builds. :)