search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
397 stars 56 forks source link

Make rubble-nrf52810 support all nRF52 chips #51

Closed jonas-schievink closed 5 years ago

jonas-schievink commented 5 years ago

The nRF52 chips are very similar (except the nRF52840, which has additional features for ZigBee and Thread - it should still work similarly though), so we should try to make the existing rubble-nrf52810 crate work with all of them.

The best way to do this is probably by renaming rubble-nrf52810 to rubble-nrf52 and then using Cargo features and #[cfg] to select a chip, similar to what the nrf52-hal-common crate does.

fmckeogh commented 5 years ago

Would now also be the time to make a rubble-nrf51 crate? (I'm working on rubble-nrf52 now)

jonas-schievink commented 5 years ago

That requires https://github.com/jonas-schievink/rubble/issues/25, so the crate wouldn't compile right now

fmckeogh commented 5 years ago

🤦‍♂️ I forgot about that :/

jonas-schievink commented 5 years ago

Fixed by https://github.com/jonas-schievink/rubble/pull/54