search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
397 stars 56 forks source link

Nrf52 Radio: Adds compiler fences to DMA code #68

Closed thalesfragoso closed 5 years ago

thalesfragoso commented 5 years ago

Formatting...

jonas-schievink commented 5 years ago

Thanks! This looks good to me, even though I'm not too familiar with how these fences work exactly. Using Acquire/Release semantics instead of the more conservative SeqCst the nrf52-hal uses also seems correct to me.

thalesfragoso commented 5 years ago

Thanks! This looks good to me, even though I'm not too familiar with how these fences work exactly. Using Acquire/Release semantics instead of the more conservative SeqCst the nrf52-hal uses also seems correct to me.

Not sure if you already looked at this but I can recommend it for a quick read: https://docs.rust-embedded.org/embedonomicon/dma.html

jonas-schievink commented 5 years ago

Ah yeah that explains it, thanks! It's been a while since I've read that book...