Do not panic when logging buffer is full

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust

BSD Zero Clause License

397 stars 56 forks source link

Do not panic when logging buffer is full #90

Closed chris-zen closed 4 years ago

chris-zen commented 4 years ago

Addressing #69

This solution removes the panic when there is not enough capacity and discards the data. It flags the data loss internally, then the next time there is enough buffer capacity it sends a message to inform that there was a loss plus the logged message and resets the flag.

jonas-schievink commented 4 years ago

Please run cargo fmt to fix CI. The code looks good to me, thanks again!

jonas-schievink commented 4 years ago

Sorry for the CI issues, I've pushed a fix to master, so if you could rebase onto master then this should pass CI as well.

chris-zen commented 4 years ago

I think that ci/upload-docs.sh is failing in Travis because the PR comes from a fork (then no secrets/credentials are available, see this). Something similar happened to me once. Anyway let me know if there is anything else I need to do ;-)