search

jonas-schievink / rubble

(going to be a) BLE stack for embedded Rust
BSD Zero Clause License
396 stars 56 forks source link

Remove logging max_level from demo-utils #95

Closed thalesfragoso closed 4 years ago

thalesfragoso commented 4 years ago

According to log docs:

Libraries should avoid using the max level features because they're global and can't be changed once they're set.

Also, see: https://github.com/rust-lang/log/issues/309

With this feature enabled here we can't pick the max_level on the demos. So currently, this line: https://github.com/jonas-schievink/rubble/blob/f8ff06cbc3de7c14636b7153bc140dad454a4505/demos/nrf52-demo/Cargo.toml#L34 or any modification has no effect.

jonas-schievink commented 4 years ago

Ah, good point. Thanks!