Closed dinesh-parthasarathy closed 11 months ago
I'm currently in the process of checking if the ExaStencils code generation still works with the proposed changes.
As soon as these changes have been made, I'd do one last integration check with the provided notebook / instructions for the Hypre backend and then I'd be happy to perform the merge.
I've now confirmed that your fork still seems to work with the ExaStencils backend at least for openjdk 11. I yet have to check the compatibility with other versions.
However, there is an issue with the evaluation (evaluate_multiple_objectives
function), since use_hypre=True
is set globally. To resolve this issue, we should introduce a parameter for that option, that either has to be specified by the user or can automatically be determined based on the context the function is called in.
I think in general, the hypre backend is not yet production-ready and probably requires some cleanup and testing. I think it is thus a better idea to merge it to a separate hypre
branch for now and perform all subsequent integration efforts there until the code is ready to be merged to the main branch. I will thus perform the merge there and would suggest that you continue working on this new branch.