search

jonas-schmitt / evostencils

Automating the Design of Multigrid Methods with Evolutionary Program Synthesis
GNU Affero General Public License v3.0
11 stars 4 forks source link

Hadrien godé #7

Closed achedrien closed 10 months ago

achedrien commented 10 months ago

Just wanted to add more flexibility and robustness to paths by using os.path.join() to avoid missing / and cwd = os.path.dirname(evostencils.file) in script's folder to automatically detect evostencils installation path. Still FAS doesn't seem to work on my installation, the problem seems to come from the make command passed line 363 of evostencils_fas.py. Please ignore tutorial.ipynb change.

I propose to add git push test (evostencils/.git/hooks/pre-push) with sript's folder file test, and an optimization_fas.py file.

jonas-schmitt commented 10 months ago

Hi Hadrien, first of all, thanks a lot for your pull request! I'm happy that things are now moving forward quite a bit.

Regarding the FAS version, I would ask @dinesh-parthasarathy too look into this, since it is mostly his implementation.

Adding some tests definitely also makes sense. Unfortunately, I currently don't have the capacity to add much functionality myself, since I can only work on this in my leisure time. I, therefore, also added you as a contributor, which should allow you to work on the main repository directly. Of course, if you prefer to work on a fork that's fine as well. In any case, I would suggest that you and Dinesh make sure to synchronize your forks/branches regularly from now on.

The usual policy is to always create merge/pull requests whenever a certain feature has been implemented and then select the other person as a reviewer and assignee. I prefer to create a separate issue and branch (which is deleted after merge) for each feature I am planning to implement, but the way you handle this is up to you.

achedrien commented 9 months ago

Thanks for the information, i didn't accept in time the reviewer invitation for this code (holiday), could you reopen it ? I will add the test myself, and adress some "to do" statement left in the code, if you are ok with it and let you and dinesh review the pull request ! btw, happy new year !