search

jonasatgit / updatereporting

MECM update reporting solution
47 stars 14 forks source link

Fix Updates Approved #17

Closed Madj42 closed 2 years ago

Madj42 commented 2 years ago

This fixes the updates approved. Until I made these changes to the reports, we were getting approved updates in the reports.

jonasatgit commented 2 years ago

Hi! I guess the description of the bar chart might be a bit misleading. It doesn't mean the update is not deployed at all; it just means the update is not deployed to the system in the list. A missing collection membership could be a reason for that. It could also mean the update is not deployed at all, if every system is in the list. But the data is meant on a per system basis. Your change to upd.IsDeployed=0 though is a per update filter and NOT a per system filter. This will exclude every deployed update, but the update might still be NOT deployed for specific systems. I hope this makes sense :-) I you agree, I will decline this change and will leave the report on a per system rather than a per update basis.

Best regards and thank you for the input! Jonas

jonasatgit commented 2 years ago

Hi! I guess the description of the bar chart might be a bit misleading. It doesn't mean the update is not deployed at all; it just means the update is not deployed to the system in the list. A missing collection membership could be a reason for that. It could also mean the update is not deployed at all, if every system is in the list. But the data is meant on a per system basis. Your change to upd.IsDeployed=0 though is a per update filter and NOT a per system filter. This will exclude every deployed update, but the update might still be NOT deployed for specific systems. I hope this makes sense :-) I you agree, I will decline this change and will leave the report on a per system rather than a per update basis.

Best regards and thank you for the input! Jonas

Madj42 commented 2 years ago

Yeah, that makes sense and it's good the way it is. I honestly never thought of that being useful in troubleshooting but it is valid and should be looked at. Thanks for the explanation.

I would think though that it would be beneficial to have another report that took these changes into account for the per update purpose. I was toying with the idea of excluding superseded updates but that would possibly exclude systems as well that hadn't scanned for the latest updates. I may look into this eventually when time allows unless someone beats me to it.

Thanks again for the explanation and reports.

On Mon, May 30, 2022, 7:28 AM Jonas Ohmsen @.***> wrote:

Hi! I guess the description of the bar chart might be a bit misleading. It doesn't mean the update is not deployed at all; it just means the update is not deployed to the system in the list. A missing collection membership could be a reason for that. It could also mean the update is not deployed at all, if every system is in the list. But the data is meant on a per system basis. Your change to upd.IsDeployed=0 though is a per update filter and NOT a per system filter. This will exclude every deployed update, but the update might still be NOT deployed for specific systems. I hope this makes sense :-) I you agree, I will decline this change and will leave the report on a per system rather than a per update basis.

Best regards and thank you for the input! Jonas

— Reply to this email directly, view it on GitHub https://github.com/jonasatgit/updatereporting/pull/17#issuecomment-1141098247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE34CSKG4TRMCWLT7SNDF4DVMSX6FANCNFSM5WFWT5UA . You are receiving this because you authored the thread.Message ID: @.***>

jonasatgit commented 2 years ago

Hi! You should be able to see all system related issues via the main "uncompliant" list. All other lists and graphs are just a breakdown of the main one. If the system has not scanned or installed for a long time, it either has a WSUS scan error in the list, hasn't installed anything in a while (Month since last update install), has missing and deployed updates, no collection in the last column, updates in error state or some deployments in unknown state. So, from my point of view there is no need for a per update state. But that's just me ;-) "Updates approved" is just there to show you either systems without the right update collection or specific updates per system not deployed. Like software you are not aware of yet, .Net Core 3.1 is a great example. Best regards Jonas