search

jonasbb / serde_with

This crate provides custom de/serialization helpers to use in combination with serde's `with`-annotation and with the improved `serde_as`-annotation.
https://docs.rs/serde_with
Apache License 2.0
638 stars 67 forks source link

Add IfIsHumanReadable #690

Closed irriden closed 7 months ago

irriden commented 7 months ago

Closes #687

Used to specify different transformations for text-based and binary formats.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eac8871) 65.29% compared to head (6d356b5) 65.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #690 +/- ## ========================================== + Coverage 65.29% 65.41% +0.11% ========================================== Files 38 38 Lines 2314 2322 +8 ========================================== + Hits 1511 1519 +8 Misses 803 803 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasbb commented 7 months ago

This already looks really good :) It has all the parts, documentation, test, and a mention in the user guide. I will merge this as is.

irriden commented 7 months ago

@jonasbb thanks for the review, any chance you can merge and release this soon ? I have a downstream PR dependent on this work here thanks :)

Also let me know if further changes are needed.

jonasbb commented 7 months ago

Sure, I published 3.6.0 containing this change. Thanks again for preparing it.

irriden commented 7 months ago

Sure, I published 3.6.0 containing this change. Thanks again for preparing it.

No problem my pleasure thank you !