Closed swlynch99 closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.25%. Comparing base (
1e4481c
) to head (dee706a
). Report is 21 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, that looks good :)
Currently, there is an
impl JsonSchema for WrapSchema<OneOrMany<...>>
. This works fine if you only directly needOneOrMany
but causes errors if you want to nest it (e.g.Option<OneOrMany<_>>
).This PR changes the impl to a
JsonSchemaAs
impl, which is the correct approach. I think I just missed these ones during a rebase. In any case, the change should be fully backwards compatible due to the blanket schema impl.I have added a snapshot test. The actual snapshot doesn't matter - the real test is that the struct below compiles