search

jonasbits / PennyPostTB

PennyPostTB is a Thunderbird Extentions and developed under http://www.gnu.org/licenses/quick-guide-gplv3.html GPLv3
http://pennypost.sourceforge.net/
10 stars 0 forks source link

Stamp display Icon is too intrusive #3

Closed ghost closed 10 years ago

ghost commented 12 years ago

So, having tested this a little it appears to work, and I like the concept and execution. Given that spamassassin apparently respects hashcash headers to some extent, I'd like to start using this.

However, screen space is premium, and the hashcash icon is badly placed, and too large. Whenever I open an email, stamped or not, there is a huge bar of extra header space intruding on the message view pane as a result of this icon.

Ideally the icon should be in line with the sender/recipients information, or at least far smaller so it produces less bar-space.

Manual editing of the messageWindowOverlay.xul file to reduce the size of the icon helped, but now header data is visible which makes up for the saved space: "x-hashcash x-stampprotocols received"

Values for these "headers" are missing. The setting for headings in the view bar is "normal".

jonasbits commented 12 years ago

Please push your changes, I lack the skills to fix this by myself. Maybe this addon could be a good example

https://addons.mozilla.org/en-US/thunderbird/addon/contact-photos/?src=search

ghost commented 12 years ago

Honestly I'm a bit of a noob too, and I can't figure out how that contact-photos extension achieves the result. I just browsed through the code on PennyPost until I found the bit corresponding to the icon. The changes I could see that could be made were: align = start // what alternatives, and what results? insertbefore = expandedHeaders // what happens if you change this, and what can it be changed to? spacer flex="1" and style = "width:64px; height:64px; margin-right:2px; margin-left:2px"

Not knowing what most of those variables referred to, I just changed the width/height and margins (that's what's in the changes I offered in the pull request entail). If I knew more about the layout of Thunderbird I might experiment with placement.

The suggested plugin you offer does things radically different: instead of creating a labelled image in XML and editing the image in javascript, it uses javascript to empty the header area entirely, and then repacks it with the image in place. Again, being a bit of a n00b I don't know how to integrate the two approaches to result in a nicely placed stamp-box.