search

jonasbkarlsson / ev_smart_charging

Electric vehicle smart charging for Home Assistant.
MIT License
140 stars 19 forks source link

Fix config entry setup warning #278

Closed hmmbob closed 4 days ago

hmmbob commented 5 days ago

Fixes #273

Tested locally

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.30%. Comparing base (8c2b880) to head (2165d02).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 99.30% 99.30% -0.01% ========================================== Files 14 14 Lines 1721 1718 -3 ========================================== - Hits 1709 1706 -3 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasbkarlsson commented 4 days ago

@hmmbob, thanks for the PR!

jonasbkarlsson commented 4 days ago

Unfortunately, this caused problems with testing for HA 2024.6. So I reverted it for now, and will look at it later.

hmmbob commented 4 days ago

Yeah, it needs 2024.7 indeed (which is also the only version where the warning will show)

jonasbkarlsson commented 4 days ago

Actually, it requires 2022.8, which was the reason why I started to remove support for 2022.7 #281 (which is the oldest version currently supported by this integration). But then there were faults in the testing for 2024.6, even though it works for all other versions (from 2022.8 and up). I'm not sure if the testing problem is due to the test code or the actual code of the integration.