jonasbn / perl-mojolicious-plugin-openapi-tutorial-hello-world

Tutorial for Mojolicious::Plugin::OpenAPI: Hello World
https://dev.to/jonasbn/tutorial-mojoliciouspluginopenapi-3jgd
MIT License
5 stars 2 forks source link

minor typo #1

Closed pscott-au closed 4 years ago

pscott-au commented 4 years ago

"Then we add the acual operation" -> "Then we add the actual operation" in README.md

jonasbn commented 4 years ago

Thanks @pscott-au I will patch accordingly - take care

pscott-au commented 4 years ago

Pod plugin I think deprecated also :)

On Tue, 10 Sep 2019 at 2:50 pm, Jonas Brømsø notifications@github.com wrote:

Thanks @pscott-au https://github.com/pscott-au I will patch accordingly

  • take care

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jonasbn/perl-mojolicious-plugin-openapi-tutorial-hello-world/issues/1?email_source=notifications&email_token=ABNAPG2SLVYDZ64TA7LIWATQI4RRPA5CNFSM4IVCAYEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JZ6OY#issuecomment-529768251, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNAPG7DV6RY5BGLHVSIAALQI4RRPANCNFSM4IVCAYEA .

jonasbn commented 4 years ago

Patched!

What POD plugin can you be more exact?

pscott-au commented 4 years ago

In hello world.pm prolly best to just remove

Documentation browser under "/perldoc"

$self->plugin('PODRenderer') if $config->{perldoc}; As this causes warnings

On Tue, 10 Sep 2019 at 2:53 pm, Jonas Brømsø notifications@github.com wrote:

Patched!

What POD plugin can you be more exact?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jonasbn/perl-mojolicious-plugin-openapi-tutorial-hello-world/issues/1?email_source=notifications&email_token=ABNAPGYF5HVNFLFAAYCOKH3QI4R55A5CNFSM4IVCAYEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6J2DNY#issuecomment-529768887, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNAPG6CKYIIOHJ2OKXW4MTQI4R55ANCNFSM4IVCAYEA .

jonasbn commented 4 years ago

Ah, that might be due to Mojolicious updates. I will investigate, I am unsure to whether I will update the code.