search

jonasbn / perl-test-timer

Test::Timer - test module to test/assert response times
https://jonasbn.github.io/perl-test-timer/
Other
1 stars 8 forks source link

time_inbetween failure #10

Closed nigelhorne closed 7 years ago

nigelhorne commented 7 years ago

If a test fails time_inbetween you get "Test did not execute within specified interval"

What you aren't told is whether it executed too quickly or too slowly.

jonasbn commented 7 years ago

Hi @nigelhorne,

That sounds like at good idea, let me see what I can do :-)

jonasbn

jonasbn commented 7 years ago

@nigelhorne I do not regard it as a failure - but a marvellous enhancement if the method could output that - thanks

nigelhorne commented 7 years ago

It if helps, I'm trying to troubleshoot http://www.cpantesters.org/cpan/report/69c755f9-6bf7-1014-ac0b-40aca26eb6e6

It seems to fail on Windows a lot - and I can reproduce it.

jonasbn commented 7 years ago

@nigelhorne Oh sounds interesting, but please report as different issue :-)

nigelhorne commented 7 years ago

That's not a bug in your software - I think it's a bug in mine, but I'm raising it here because I'm using your software to test/debug mine. It's just an FYI.

jonasbn commented 7 years ago

@nigelhorne np, I will try to implement your requirement ASAP

jonasbn commented 7 years ago

First shot at implementation available in branch. I need to work a bit on the docs, but if you have the time, your feedback could prove valuable.

nigelhorne commented 7 years ago

At first glance it seems fine, thanks, but I need to test and that'll take some doing on a Windoze box :-(

First shot at implementation available in branch https://github.com/jonasbn/perl-test-timer/tree/issue10. I need to work a bit on the docs, but if you have the time, your feedback could prove valuable.

jonasbn commented 7 years ago

@nigelhorne I will make the official release tomorrow, it is getting late and I want to make sure I remembered everything - I hope that is okay

jonasbn commented 7 years ago

Good morning @nigelhorne,

Release 1.00 has just uploaded to PAUSE/CPAN, let me know if you experience any issues. I know your request was not a huge thing. But I actually value the suggestion, I do not know why I dit not see the opportunity myself. Made the release a major release since feedback from the module changed. Again thanks for your suggestion, I hope the release implementation helps you.

nigelhorne commented 7 years ago

Sorry it's taken me sometime to test this. I now get this message:

Test did not execute within specified interval 1 - 6 seconds

Which still doesn't tell me if it took <1 or if it took >6 seconds.

jonasbn commented 7 years ago

Don't apologize - I am just glad that you can take the time :-)

I will investigate if I can present the actual calculated execution time. Which sound doable

jonasbn commented 7 years ago

Hi @nigelhorne, Please see issue #12 - I have moved your request here.