jonasbn / perl-test-timer

Test::Timer - test module to test/assert response times
https://jonasbn.github.io/perl-test-timer/
Other
1 stars 8 forks source link

time_atleast > should be >= #15

Closed nigelhorne closed 7 years ago

nigelhorne commented 7 years ago

See http://www.cpantesters.org/cpan/report/aa2b3bdb-6bf3-1014-8790-aa4ee6406fa7

It comes from this test:

time_atleast(sub { $response = $ua->get('http://search.cpan.org/'); }, 9, 'should be fully throttled');

Given that it did indeed take at least 9 seconds (it took 9 seconds) that test shouldn't have failed, IMO.

jonasbn commented 7 years ago

Hi @nigelhorne

I am sorry about the long response time, I started cleaning the code a bit after you raised #14, this introduced some instability. I have now stabilised the distribution and will make a release. I have implemented your suggestion.

A release (2.02) should make it to PAUSE/CPAN shortly - have a nice weekend

nigelhorne commented 7 years ago

No problem about the delay. Thanks. I'll take a look as soon as I can.

jonasbn commented 7 years ago

Thanks! and it goes the other way, just whenever you get the time