search

jonascarpay / calligraphy

haskell source code visualizer
BSD 3-Clause "New" or "Revised" License
97 stars 13 forks source link

Support for GHC 9.6 #20

Closed Kleidukos closed 1 year ago

Kleidukos commented 1 year ago

Mostly CPP for imports.

closes #19

jonascarpay commented 1 year ago

Thanks! Would you mind cherrypicking/rebasing onto https://github.com/jonascarpay/calligraphy/tree/ghc96? It adds GHC 9.6 and should now properly trigger on PRs.

Kleidukos commented 1 year ago

Sure! Btw, when you said that you preferred to merge to "staging" branches, I didn't immediately understand it. Would you consider having development for merging PRs and main whence they are released?

jonascarpay commented 1 year ago

Oh, no, I don't think we need a separate development branch. I'm happy to just have feature branches that merge into main, as long as every merge commit is green. For #17 I needed to bump and fix CI before merging, and since it didn't trigger on PRs yet that was the quickest way for me to do that.

jonascarpay commented 1 year ago

Hmm, I'll take a look at the Nix failure