jonase / eastwood

Clojure lint tool
1.09k stars 66 forks source link

Change exit code when no namespaces were linted and caching is enabled #453

Closed kjothen closed 4 months ago

kjothen commented 4 months ago

No longer consider No namespaces linted. as a warning if :only-modified true and the .eastwood file contains a valid timestamp.

Linting a large monorepo is time-consuming in CI builds. This can be mitigated by caching the .eastwood file between runs on the same branch. However, eastwood returns a non-zero exit code when no namespaces were linted, which is problematic. Rather than ignore the error code and continue the build, it would be better to return a zero error code in this circumstance.

Fixes: #454


Before submitting the PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

Thanks!

kjothen commented 4 months ago

Yeah, 3 mins is very manageable, but I remember when it was < 1 min in our early days, so it's crept up on us for sure! I made the changes you suggested, and thanks again.

vemv commented 4 months ago

Thanks to you!

I've tagged 1.4.3 - a release should be generated in < 1h.