search

jonasgeiler / svelte-infinite-loading

An infinite scroll component for Svelte, to help you implement an infinite scroll list more easily.
MIT License
304 stars 11 forks source link

window.remove vs window.removeEventListener in third argument detection. #5

Closed whataboutpereira closed 3 years ago

whataboutpereira commented 3 years ago

https://github.com/Skayo/svelte-infinite-loading/blob/86b3f25adcf4c3c27ab06483b9ae5b1eea1668ed/src/InfiniteLoading.svelte#L39-L40

I looked at the referenced EventListenerOptions doc and suspect window.remove should be window.removeEventListener here?

jonasgeiler commented 3 years ago

Yes! You're right. Will fix that...

I think I just copy pasted the code from somewhere