jonasgwt / pe

0 stars 0 forks source link

Able to add two similar identical tags but of different case without warning #4

Open jonasgwt opened 1 year ago

jonasgwt commented 1 year ago

Steps to reproduce:
Execute tag add 2 t/Friends to person at index 2 who already has tag friends

Expected Output:
The contact already has the tag

Actual Output:
The tag is added. The person now has 2 tags called friends

Screenshots:

Screenshot 2022-11-11 at 4.30.55 PM.png

nus-se-bot commented 1 year ago

Team's Response

It is not a bug, because we deliberately design the tag to be able to differentiate between case-sensitive words. For example, a user might have a pool of contacts to watch a sitcom called "Friends" together and want to have tag "friends" for the user's actual friends. Hence why they are interpreted differently. That's why in our UG, we never say that tag is case-insensitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Although there is a genuine use case that the team has mentioned, the problem that a user might mistakenly add a similar tag but of a different case still remains a very real problem. To cater to both use cases, a warning, as indicated in the title of the bug report, should be the expected behaviour of the application.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]