jonashaag / audio-resampling-in-python

Comparison of Python audio resampling implementations
42 stars 8 forks source link

Fix dynamic range of sweep plots, impulse comparision #2

Closed dofuuz closed 3 years ago

dofuuz commented 3 years ago

Fixes #1

Ran on Google Colab: https://colab.research.google.com/drive/1ULnW9PoclISVNxVqDxycf7OHMs_azghi?usp=sharing

Jupyter Notebook Viewer: https://nbviewer.jupyter.org/github/dofuuz/audio-resampling-in-python/blob/range/Audio%20Resampling%20in%20Python.ipynb

Original version has different dynamic ranges for each sweep plots. So, same color dose not means same dB.

This PR makes all plots have same dynamic range for fair comparison. (-150dB ~) And uses friendly 'inferno' colormap.

dofuuz commented 3 years ago

I didn't changed any text section of notebook.

Here is my opinion:

I think it's better to remove opinion-based text section on ipynb notebook if you are not going to update it.

dofuuz commented 3 years ago

Fixed issue #1

adefossez commented 3 years ago

Thanks @dofuuz for the fix :)