search

jonashaag / klaus

docker run klaus / pip install klaus — the first Git web viewer that Just Works™.
http://klausdemo.lophus.org
Other
685 stars 101 forks source link

Filenames not correctly escaped in commit diff view #245

Closed s-ol closed 5 years ago

s-ol commented 5 years ago

Filenames containing > (and presumably other special chars) get HTML-entity-escaped twice. This shows up in the UI, but it also happens to the <a href that links to the file, rendering the link unusable.

a live example: commit in question: https://git.s-ol.nu/mmm/commit/2deac635b84447351f0b314c9fbe66743df488d1/ file is displayed as: .../pinwall/text$moonscript -&gt; fn -&gt; mmm$dom.moon (should have been .../pinwall/text$moonscript -> fn -> mmm$dom.moon)

The link goes here, but should go here.

s-ol commented 5 years ago

Nevermind. I finally managed to get my own Dockerfile working, which got me moving off of v0.7 or something. This was probably fixed years ago.