python 3.12 support - Githubissues

jonashaag / klaus

docker run klaus / pip install klaus — the first Git web viewer that Just Works™.

http://klausdemo.lophus.org

Other

686 stars 102 forks source link

python 3.12 support #334

Closed fin444 closed 4 months ago

fin444 commented 4 months ago

remove references to distutils

app_args.py: add polyfill
setup.py: remove code that hasn't been necessary since 51094d7

jonashaag commented 4 months ago

Thanks for the patch! Do you think you know what you're doing here? Because I don't when it comes to these packaging things and have no way of verifying because I have no clue what's right and wrong. So I'll have to trust your judgment here.

jonashaag commented 4 months ago

Also, if you think we should be doing larger cleanup of packaging, feel free to come up with more PRs. The packaging infrastructure of this project is easily 10 years old and hasn't seen much love since then.

jelmer commented 4 months ago

FWIW this looks good to me.

fin444 commented 4 months ago

I'm not exactly an expert on this, but for app_args.py it's just copy pasting the function from the library. For setup.py, what I found suggested that the hack was only necessary if data_files was included as a parameter (source 1, source 2, source 3 it just says it in the comment)

fin444 commented 4 months ago

And while clean up would be cool, I don't know much about packaging lol. I only submitted this because NixOS updated to 3.12 and it broke my stuff