jonaskohl / CapsLockIndicator

A small utility that indicates the state of the Num lock, Caps lock and Scroll lock key.
https://cli.jonaskohl.de/
Apache License 2.0
336 stars 41 forks source link

redundant IsDispose checks to preclude operation on their respective … #77

Closed Yetoo1 closed 2 years ago

Yetoo1 commented 3 years ago

…fail states.

Before I added the IsDisposed in ShowOverlay, I tested with it just in ClickThroughWindow and it failed, but I would keep it there just for redundancy. if (!indicatorOverlay.IsDisposed) in ShowOverlay seems to be doing the trick.

58

Yetoo1 commented 3 years ago

Tested to work for 4 trials of TF2-Steam lag method and a an hour played in TF2 with lots of lag, loading screens freezing up the program, and swapping that was tested while running this change in debug mode while simultaneously pressing caps lock did not cause the program to break or to throw an exception.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed because there has not been any new activity since it has been marked as stale.