jonasman / MulticastDelegate

An elegant multicast delegate written in swift
MIT License
148 stars 28 forks source link

MulticastDelegate.delegates property changed to 'let' #7

Closed bubski closed 8 years ago

bubski commented 8 years ago

NSHashTable is a reference type so it should be a constant.

JRG-Developer commented 8 years ago

AFAICT, this appears to be a safe change...

(1) All of the unit tests pass, which includes tests that use the custom operator functions. (2) Since delegates is private, consumers can't access it directly, so this minimizes concerns about breaking code in consumers' code.

I think this should be merged...

Thoughts, @jonasman ?

jonasman commented 8 years ago

sounds good!