search

jonasman / TeslaSwift

Swift library to access the Tesla API
MIT License
243 stars 72 forks source link

getPartnerToken and registerApp declared internal, can't call them #158

Closed gshaviv closed 10 months ago

gshaviv commented 10 months ago

I've imported TeslaSwift to a playground where I attempted to getPartnerToken and registerApp but can't cause they are declared internal so playground doesn't compile. Need to fix and declare them public so they can be used not just from within the package.

jonasman commented 10 months ago

Can you make a pr to make them public? Sent from my iPhone

On 30 Nov 2023, at 16:39, Guy Shaviv @.***> wrote:



I've imported TeslaSwift to a playground where I attempted to getPartnerToken and registerApp but can't cause they are declared internal so playground doesn't compile. Need to fix and declare them public so they can be used not just from within the package.

— Reply to this email directly, view it on GitHubhttps://github.com/jonasman/TeslaSwift/issues/158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANOMXXX4VFTYWNCOQ3DVZTYHCLBZAVCNFSM6AAAAABABJSMLCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTQOBQG4YTMOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

gshaviv commented 10 months ago

https://github.com/jonasman/TeslaSwift/pull/159