jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
933 stars 50 forks source link

Fix imports in TypeScript #41

Closed alex-grover closed 2 years ago

alex-grover commented 2 years ago

Description

Fixes #38 by adding an index file in the root directory, and converting the existing index file to .ts. This is the pattern used in the community template. It looks like the official template uses an index.js, but that seems not to work if you try to import types from that file.

A few other small changes:

Testing

alex-grover commented 2 years ago

@jonasmerlin if you're open to it, I can also add a CI job so issues like the package.json typo get caught in the PR. let me know!

jonasmerlin commented 2 years ago

@alex-grover Whoa, nice work! Thank you so much for looking into this. Always glad to accept help from a fellow Colemak-DH user. 😁

The CI job would be super helpful as well. Sadly I don't have much time to maintain this project beyond accepting PRs etc. right now. So anything that catches things early is very welcome.

I will merge this and you create a separate PR for the CI, alright?

alex-grover commented 2 years ago

sounds good!