jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
908 stars 50 forks source link

Please consider providing a way to disable the same title warning #61

Closed maxcountryman closed 1 year ago

maxcountryman commented 1 year ago

Specifically, this line.

It's quite opinionated to suggest the OG title should not be the same as the page title: it entirely depends on the page and application. (I understand the point that the linked Tweet is making but it's not relevant to my use case, which uses the heading as the page title and therefore both title and OG title are the same value.)

If it were me, I would remove this altogether and leave it up to the user to decide how they want to configure their site.

Screenshot 2023-02-21 at 4 51 50 PM
jonasmerlin commented 1 year ago

If it were me, I would remove this altogether and leave it up to the user to decide how they want to configure their site.

Are you so sure about that? 😜

Just kidding, really. Having an option to disable it is a fair point, I'll try to put a toggle in with the next version.

raulfdm commented 1 year ago

That would be great, indeed.

Either have a config option to disable that or warn once. I do want my title and og:title to be the same.

jonasmerlin commented 1 year ago

@raulfdm Sorry for the delay, but this has now landed in 0.7.2

You can pass surpressWarnings={true} and it should hide the warnings!

raulfdm commented 1 year ago

Thanks @jonasmerlin . Worked like a charm